797521 - Show breakdown of reviewer points on individual history page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[krupa raj[:krupa]]

The Editors want app review points to show up on Marketplace and add-on review points to show up on AMO. Currently they show up in both places.

We should fix that.

Comment 1

[Rob Hudson [:robhudson]]

On AMO I'm assuming you want all review points that aren't apps, right? And not just add-on review points.

Comment 2

[krupa raj[:krupa]]

Amy is happy for admins to be able to see the breakdown of a particular editor's overall score

So, As an admin if I search for an editor I should be able to see 

Overall score:
Add-on review points:
App review points:
Persona review points:
Editor since:

As an Editor, they will only see their overall score (i think)

Comment 3

[Rob Hudson [:robhudson]]

What I think would be nice is:

Have the user's reviewer scores be a page unto itself, something like /reviewers/user/robhudson. On that page show stuff like:
* total points
* current level
* number of points to the next level
* breakdown of points by add-on type (if the user also reviews add-ons, e.g.)
* point history

This page would be viewable by all other reviewers and admins.

Comment 4

[krupa raj[:krupa]]

(In reply to Rob Hudson [:robhudson] from comment #3)
> What I think would be nice is:
> 
> Have the user's reviewer scores be a page unto itself, something like
> /reviewers/user/robhudson. On that page show stuff like:
> * total points
> * current level
> * number of points to the next level
> * breakdown of points by add-on type (if the user also reviews add-ons, e.g.)
> * point history
> 
This should not block us from pushing the RI live. It is a great idea though.
> This page would be viewable by all other reviewers and admins.

Comment 5

[Rob Hudson [:robhudson]]

Attachment: Reviewer scores overview page

Comment 6

[Rob Hudson [:robhudson]]

Amy: Could you look at this and comment if it's enough? I snuck in a little bit of work on this Friday afternoon. It'd be nice to do more but this is all I was able to do.

Comment 7

[Andrew Williamson [:eviljeff]]

We already have https://addons.mozilla.org/editors/performance/ - it seems like that would be a good place to have the points too, rather than creating a new page.  

That page could have the detailed breakdown like in your overview screenshot (there is a dropdown at the top that lets you switch between users).

Comment 8

[Andrew Williamson [:eviljeff]]

clarifying which bugs are for which things.  The other related bug is bug 739434

Comment 10

[Wil Clouser [:clouserw]]

This is half done so bumping into this milestone

Comment 11

[Rob Hudson [:robhudson]]

My plan:

* Put just the breakdown part in AMO with the other performance data, under the chart.
* Make a similar URL on mkt with the idea that we'd eventually add more reviewer performance data, but for now only the breakdown will be there.

The history can be viewed from the model admin by admins if need be. You can also add ?user=<user_id> to the URL once you're there to filter by user ID. Because of this I'm dropping this part.

Comment 12

[Rob Hudson [:robhudson]]

I didn't get to this at all this week. But the plan above still holds.

Comment 13

[Rob Hudson [:robhudson]]

On AMO:
https://addons-dev.allizom.org/en-US/editors/performance/

AMO also has a editor dropdown menu for admins that adds the ID to the URL above.

MKT:
https://marketplace-dev.allizom.org/reviewers/performance/

MKT does not have an editor dropdown menu for admins but if you append the username you can view other user's points. E.g.
https://marketplace-dev.allizom.org/reviewers/performance/robhudson

Feel free to file new bugs to expand on either of the above.

Comment 14

[Andrew Williamson [:eviljeff]]

The implementation is as per the spec in the earlier comments but my feeling is we'll want it broken down further than just Add-on/App as the majority of reviewers will only do one type.  @atsay, any preference?

Comment 15

[Amy Tsay [:amyt]]

Yes, we don't expect very much crossover between add-ons and apps reviewers. So it would be useful to have something like the Recent History section you mocked up here https://bug797521.bugzilla.mozilla.org/attachment.cgi?id=669197

Comment 16

[Andrew Williamson [:eviljeff]]

(In reply to Amy Tsay [:amyt] from comment #15)
> Yes, we don't expect very much crossover between add-ons and apps reviewers.
> So it would be useful to have something like the Recent History section you
> mocked up here
> https://bug797521.bugzilla.mozilla.org/attachment.cgi?id=669197

Do reviewers need that level of history detail?  Maybe something in between more like the review performance, where it shows current month, year, etc? (Admins can get the full breakdown via a model in /admin btw.)

Comment 17

[Amy Tsay [:amyt]]

Sure, that sounds fine to me.

Comment 18

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/reviewers/performance/ on FF20 (Win 7)
Attaching postfix screenshot.
Closing bug.

Comment 19

[Cristian Boldan]

Attachment: postfix reviewer points